[Webkit-unassigned] [Bug 56156] Add setting to always force compositing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56156





--- Comment #15 from Daniel Sievers <sievers at google.com>  2011-03-16 14:13:49 PST ---
(From update of attachment 85894)
View in context: https://bugs.webkit.org/attachment.cgi?id=85894&action=review

>> Source/WebCore/rendering/RenderLayerCompositor.cpp:118
>> +        && !m_renderView->document()->frame()->tree()->parent()) {
> 
> this indentation is odd - i'd try to make it clearer that line 118 is still inside the conditional and line 119 is not, maybe line up the &&s or something

I agree that it looks odd, but I ended up leaving it that way because this seems to be done commonly that way in the WebKit code, and it actually looks a bit odd too if I align it with the &&.

>> Source/WebCore/rendering/RenderLayerCompositor.h:279
>> +
> 
> nitpick: i think it'd be better to declare this with the other bools

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.