[Webkit-unassigned] [Bug 55859] [Chromium] The method that retrieves all resources from a page should be moved from Chromium to WebKit
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 16 13:53:34 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=55859
--- Comment #14 from Jay Civelli <jcivelli at chromium.org> 2011-03-16 13:53:34 PST ---
(In reply to comment #13)
> (From update of attachment 85884 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85884&action=review
>
> WebPageSerializer.cpp is such great sadness. I re-wrote the whole thing, but never landed the new version. :(
>
> Almost every line of code in that file is wrong.
And it's only going to get worse, as I am planning to add some more code in that file :-)
I looked at the other file briefly (WebPageSerializerImpl.cpp) and was also concerned. Any reason why you did not land your new version? Anything I can do to help?
> > Source/WebKit/chromium/src/WebPageSerializer.cpp:60
> > +KURL getSubResourceURLFromElement(const Element& element)
>
> I usually pass Elements by pointer, not by reference.
OK
> > Source/WebKit/chromium/src/WebPageSerializer.cpp:92
> > + if (value.isNull() || value.isEmpty() || value.startsWith("javascript:", false))
>
> value.startsWith("javascript:", false) is wrong. It could start with " javascript:" also, for example.
OK, now stripping white-space.
> > Source/WebKit/chromium/src/WebPageSerializer.cpp:106
> > + if ((element.hasTagName(HTMLNames::iframeTag) || element.hasTagName(HTMLNames::frameTag))
> > + && element.isFrameOwnerElement()) {
>
> What if it's an object or an embed element that has a frame?
Now supported.
> > Source/WebKit/chromium/src/WebPageSerializer.cpp:114
> > + if (url.isEmpty() || url.isNull() || !url.isValid())
>
> isEmpty includes isNull, right?
Oh, yeah.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list