[Webkit-unassigned] [Bug 55571] [Refactoring] Auto correction panel should be handled by its own class.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55571





--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-16 12:35:11 PST ---
(From update of attachment 85922)
View in context: https://bugs.webkit.org/attachment.cgi?id=85922&action=review

> Source/WebCore/editing/CorrectionPanelController.cpp:81
> +CorrectionPanelController::~CorrectionPanelController()
> +{
> +#if SUPPORT_AUTOCORRECTION_PANEL
> +    dismissCorrectionPanel(ReasonForDismissingCorrectionPanelIgnored);
> +#endif
> +}

It might be better to have EmptyCorrectionPanelController so that we don't have to put if-endif in all of these functions.

> Source/WebCore/editing/Editor.cpp:-2298
> -#if SUPPORT_AUTOCORRECTION_PANEL
>      // If this checking is only for showing correction panel, we shouldn't bother to mark misspellings.
>      if (shouldShowCorrectionPanel)
>          shouldMarkSpelling = false;
> -#endif

Why is it safe to remove this if-endif?

> Source/WebCore/editing/Editor.cpp:-3521
> -#if SUPPORT_AUTOCORRECTION_PANEL
>          // Don't check spelling and grammar if the change of selection is triggered by spelling correction itself.
>          shouldCheckSpellingAndGrammar = !(options & SelectionController::SpellCorrectionTriggered);
> -#endif

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.