[Webkit-unassigned] [Bug 56156] Add setting to always force compositing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56156


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85894|review?                     |review+
               Flag|                            |




--- Comment #13 from James Robinson <jamesr at chromium.org>  2011-03-16 11:05:59 PST ---
(From update of attachment 85894)
View in context: https://bugs.webkit.org/attachment.cgi?id=85894&action=review

Looks good!

> Source/WebCore/rendering/RenderLayerCompositor.cpp:118
> +    if (settings && settings->forceCompositingMode() && settings->acceleratedCompositingEnabled()
> +        && !m_renderView->document()->frame()->tree()->parent()) {

this indentation is odd - i'd try to make it clearer that line 118 is still inside the conditional and line 119 is not, maybe line up the &&s or something

> Source/WebCore/rendering/RenderLayerCompositor.h:279
> +    bool m_forceCompositingMode;
> +

nitpick: i think it'd be better to declare this with the other bools

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.