[Webkit-unassigned] [Bug 49508] RTL: Caret can paint over letters when in the end of a line in textareas

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49508


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85494|review?                     |review-
               Flag|                            |




--- Comment #5 from Dave Hyatt <hyatt at apple.com>  2011-03-16 10:09:15 PST ---
(From update of attachment 85494)
View in context: https://bugs.webkit.org/attachment.cgi?id=85494&action=review

You got the vertical text case wrong, so might want to make a vertical text test (you'll have to use a normal contenteditable div for that though, since textareas don't go vertical.)

> Source/WebCore/rendering/RenderText.cpp:533
> +        rightEdge = cb->width();

Should be rightEdge = cb->logicalWidth();

> Source/WebCore/rendering/RenderText.cpp:536
> +        rightEdge = max(static_cast<float>(cb->width()), rootRight);

Should be logicalWidth().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.