[Webkit-unassigned] [Bug 55072] Make OpenGL implementation of the GraphicsContext3D class shareable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55072


Zan Dobersek <zandobersek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83783|0                           |1
        is obsolete|                            |




--- Comment #5 from Zan Dobersek <zandobersek at gmail.com>  2011-03-16 08:56:11 PST ---
Created an attachment (id=85933)
 --> (https://bugs.webkit.org/attachment.cgi?id=85933&action=review)
Proposed changes

This patch includes the following:

- 91 extensible functions are added to the Extensions3DOpenGL class. These functions are meant to be implemented for each port that uses OpenGL implementation of GraphicsContext3D separately. A comment explaining the situation is added at the top of these functions.
- An implementation is included for the Mac port, located in platform/graphics/mac/Extensions3DOpenGLMac.cpp. The implementation is basically using the same OpenGL functions as they were used in GraphicsContext3DOpenGL.cpp. I'd like some input on whether this should be a .mm file or a .cpp file (as it is currently - I'm not familiar with the Mac build). I'd also be grateful if someone with access to a Mac build could add this file (Extensions3DOpenGLMac.cpp) to the build.
- Call to every OpenGL function in GraphicsContext3DOpenGL.cpp that could be extensible is replaced with an appropriate call to a Extensions3DOpenGL class function. This is the part of the patch that really introduces shareable GC3D. The same is done in GraphicsContext3DMac.cpp.
- Extensions3DOpenGL::blitFramebuffer and Extensions3DOpenGL::renderbufferStorageMultisample are moved to Extensions3DOpenGLMac.cpp and are still executing the same OpenGL calls.

With these modifications the Gtk port (and any other port that would want to use OpenGL GC3D) simply needs to implement functions of Extensions3DOpenGL class in a way that calls those extensions functions that are actually available.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.