[Webkit-unassigned] [Bug 56445] New: Logic error in -[WebHTMLView close]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56445

           Summary: Logic error in -[WebHTMLView close]
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh Intel
        OS/Version: Mac OS X 10.6
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: opendarwin at lapcatsoftware.com


The following code is in -[WebHTMLView close]:

    [_private clear];

    Page* page = core([self _webView]);
    if (page)
        page->dragController()->setDraggingImageURL(KURL());

However, -[WebHTMLViewPrivate clear] has this code:

    dataSource = nil;

And -[WebHTMLView _webView] is as follows:

- (WebView *)_webView
{
    return [_private->dataSource _webView];
}

Thus, the call to [self _webView] always returns nil after [_private clear], and page will always be nil too.

The "page" code in-[WebHTMLView close] was introduced in <https://trac.webkit.org/changeset/19104>. I'd say it's hard to image that this section of code was ever tested.

I discovered this logic error while investigating https://bugs.webkit.org/show_bug.cgi?id=26667

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.