[Webkit-unassigned] [Bug 56421] Devirtualize isContentEditable and isRichlyContentEditable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56421





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-15 18:05:37 PST ---
(From update of attachment 85888)
View in context: https://bugs.webkit.org/attachment.cgi?id=85888&action=review

> Source/WebCore/dom/Node.h:331
> +    bool isContentEditable() const { return isContentEditable(false); }
> +    bool isContentRichlyEditable() const { return isContentEditable(true); }

I'm not happy about the fact these two functions call isContentEditable with true/false but I wasn't sure about it's worth adding an enum just so that these two functions can use it.  Given that isContentEditable is Node's private function, it seems okay to use raw boolean values here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.