[Webkit-unassigned] [Bug 56421] Devirtualize isContentEditable and isRichlyContentEditable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56421





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-15 16:21:19 PST ---
(From update of attachment 85870)
View in context: https://bugs.webkit.org/attachment.cgi?id=85870&action=review

> Source/WebCore/dom/Node.cpp:720
> +    if (document()->inDesignMode())
> +        return true;

This is a very expensive call.  It'll traverse all parent frames.  Given that this function walks the nodes up, isContentEditable is O(nk) where n is the number of nodes in the current document and k is the number of parent documents.  I don't think this is acceptable.  We should make it O(n+k).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.