[Webkit-unassigned] [Bug 53384] RenderFullScreen::createFullScreenStyle() leaks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53384





--- Comment #6 from Adam Roben (:aroben) <aroben at apple.com>  2011-03-15 15:25:34 PST ---
(In reply to comment #2)
> Looks like the last line of createFullScreenStyle() should be changed from:
> 
>     return fullscreenStyle;
> 
> to:
> 
>     return fullscreenStyle.release();
> 
> As per the "Mixing RefPtr and PassRefPtr" section of http://webkit.org/coding/RefPtr.html.

That would be a good change to make. But I don't think it will have any effect on this leak. All it will do is save an unnecessary ref()/deref() pair from occurring.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.