[Webkit-unassigned] [Bug 53590] Can't exec "WebKit/Tools/Scripts/print-vse-failure-logs"

Tue Mar 15 09:09:53 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=53590

Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85801|review?                     |review-
               Flag|                            |

--- Comment #16 from Adam Roben (:aroben) <aroben at apple.com>  2011-03-15 09:09:53 PST ---
(From update of attachment 85801)
View in context: https://bugs.webkit.org/attachment.cgi?id=85801&action=review

> Tools/ChangeLog:8
> +        * Scripts/webkitdirs.pm:

It would be good to add a function-level comment explaining this change. Something like:

(relativeScriptsDir): Ensure we use the directory that contains webkitdirs.pm, not the one that contains the original script that was invoked.

> Tools/Scripts/webkitdirs.pm:1
> -# Copyright (C) 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
> +ï»¿# Copyright (C) 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.

Please undo this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.