[Webkit-unassigned] [Bug 55217] [GStreamer] Frame accurate seeking isn't always accurate
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 15 08:01:56 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=55217
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85789|review? |review+
Flag| |
--- Comment #10 from Martin Robinson <mrobinson at webkit.org> 2011-03-15 08:01:56 PST ---
(From update of attachment 85789)
View in context: https://bugs.webkit.org/attachment.cgi?id=85789&action=review
Looks good to me!
> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:524
> + GTimeVal timeValue;
> + float seconds;
> + float microSeconds = modf(time, &seconds) * 1000000;
> + timeValue.tv_sec = static_cast<glong>(seconds);
> + timeValue.tv_usec = static_cast<glong>(roundf(microSeconds / 10000) * 10000);
Super nit here, but do you mind moving GTimeVal timeValue right down to where you first use it?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list