[Webkit-unassigned] [Bug 56196] Some class members were used prior to initialization

Tue Mar 15 02:28:49 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56196

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85478|review?                     |review+, commit-queue+
               Flag|                            |

--- Comment #5 from Adam Barth <abarth at webkit.org>  2011-03-15 02:28:49 PST ---
(From update of attachment 85478)
View in context: https://bugs.webkit.org/attachment.cgi?id=85478&action=review

I'm hesitating to accept this patch without tests.  Usually we require all patches to have associated tests, if they change any observable behavior.  In this case, you should be able to write a test that trigger the UMRs.  However, I'm marking this patch r+ because I'd like to encourage you to upstream more patches.  Thanks for the patch.

> Source/WebCore/accessibility/AccessibilityImageMapLink.cpp:45
> +    , m_parent(0)

wow!

> Source/WebCore/xml/XPathResult.cpp:45
> +    , m_nodeSetPosition(0)
> +    , m_domTreeVersion(0)

!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.