[Webkit-unassigned] [Bug 56324] EventHandler calls shouldChangeSelection needlessly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56324





--- Comment #2 from Darin Adler <darin at apple.com>  2011-03-14 17:51:44 PST ---
(From update of attachment 85746)
View in context: https://bugs.webkit.org/attachment.cgi?id=85746&action=review

> Source/WebCore/page/EventHandler.cpp:662
> -    if (m_frame->selection()->shouldChangeSelection(newSelection)) {
> -        m_frame->selection()->setIsDirectional(false);
> -        m_frame->selection()->setSelection(newSelection, m_frame->selection()->granularity(), MakeNonDirectionalSelection);
> -    }
> +    setNonDirectionalSelectionIfNeeded(m_frame->selection(), newSelection, m_frame->selection()->granularity());

What does the setIsDirectional(false) work in the new code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.