[Webkit-unassigned] [Bug 56043] Leaks Viewer should present a list of recent builds to analyze

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56043





--- Comment #8 from Adam Roben (:aroben) <aroben at apple.com>  2011-03-14 15:09:53 PST ---
(From update of attachment 85721)
View in context: https://bugs.webkit.org/attachment.cgi?id=85721&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:178
>> +                link.href = document.location.href + "?url=" + build.url;
> 
> I think this should window.encodeURIComponent(build.url)

Doing this by itself breaks the link. I need to add a decodeURIComponent call where we read this out of the URL. I've now done that.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:57
>> +                            buildInfo.leakCount = match[1];
> 
> Nit: optional, parseInt(match[1], 10) since it looks like you want this to be a numerical value.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.