[Webkit-unassigned] [Bug 49649] [GTK] On-demand event-listeners for DOM event signals

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 13:44:00 PDT 2011


--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2011-03-14 13:44:00 PST ---
(From update of attachment 80347)
View in context: https://bugs.webkit.org/attachment.cgi?id=80347&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1088
>> +${lowerCaseIfaceName}_add_event_listener(${className}* self, const char* eventName, GCallback handler, gboolean useCapture, gpointer user_data);
> An interface may mean these will go away, but WebKit-style dictates that there should be no newline after the return type for these methods.

Sorry. Let me clarify. This particular line is okay. Our style guidelines are kind of wonky. For header files we use the style you are using here. Below, for the implementation files, we do not add the newline and use WebKit style everywhere. The GObject binding code has the wrong style many places, but we are trying to fix it as we go along.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1100
> +WEBKIT_API gboolean
> +${lowerCaseIfaceName}_add_event_listener(${className}* self, const char* eventName, GCallback handler, gboolean useCapture, gpointer user_data)
> +{
> +    ${coreSelf}
> +    return WebCore::GObjectEventListener::addEventListener(G_OBJECT (self), coreSelf, eventName, handler, useCapture, user_data);
> +}

So for instance here, you would not use the newline.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list