[Webkit-unassigned] [Bug 49345] Add Support to WebCore to optionally call an optional platform-specific gesture recognizer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49345





--- Comment #47 from Benjamin Poulain <benjamin at webkit.org>  2011-03-14 12:49:29 PST ---
(From update of attachment 85387)
View in context: https://bugs.webkit.org/attachment.cgi?id=85387&action=review

My comments:
-I would have kept the ENABLE_GESTURE_MANAGER. This is experimental feature at the moment since you don't have the full implementation ready. I would guard whatever goes in WebCore for now. If this WebCore gesture recognition end up being the default for touch event handling, the ENABLE_GESTURE_MANAGER can be removed. If adding the gesture support in WebCore end up being impractical in the end, then we can remove the code guarded by ENABLE_GESTURE_MANAGER. So for now I like the #define (maybe that has already been discussed and I missed the thread?)
-Other ports than chromium and Qt are defining ENABLE_TOUCH_EVENTS (at least EFL, and probably WinCE). Those won't build now since EventHandler reference PlatformGestureRecognizer.

> Source/WebCore/page/EventHandler.h:38
> +#include <wtf/PassOwnPtr.h>

Probably not necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.