[Webkit-unassigned] [Bug 56263] XML Viewer: extensions can't render original XML

Mon Mar 14 12:27:46 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56263

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85699|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #11 from Adam Barth <abarth at webkit.org>  2011-03-14 12:27:46 PST ---
(From update of attachment 85699)
View in context: https://bugs.webkit.org/attachment.cgi?id=85699&action=review

This patch seems like a hack.  We're randomly dropping something in the global scope that extensions can key off of to trigger a quirk w.r.t. opener that's we're probably going to remove anyway.

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

This line will prevent this patch from landing.  Can we write a test for this change?

> Source/WebCore/xml/XMLViewer.xsl:253
> -                    <span> <xsl:value-of select="$xml_has_no_style_message"/> </span> 
> +                    <span> <xsl:value-of select="$xml_has_no_style_message"/> </span>

This change seems unrelated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.