[Webkit-unassigned] [Bug 45164] REGRESSION: <a><img align=top></a> Clickable area too large

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45164


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76489|review?                     |review-
               Flag|                            |




--- Comment #7 from Dave Hyatt <hyatt at apple.com>  2011-03-14 12:21:00 PST ---
(From update of attachment 76489)
View in context: https://bugs.webkit.org/attachment.cgi?id=76489&action=review

This isn't right.

> WebCore/rendering/InlineFlowBox.cpp:597
> +            int posAdjust = 0;
>              if ((isInlineFlow && !static_cast<InlineFlowBox*>(curr)->hasTextChildren()) && !curr->boxModelObject()->hasInlineDirectionBordersOrPadding() && !strictMode)
>                  childAffectsTopBottomPos = false;
> -            int posAdjust = maxAscent - curr->baselinePosition(baselineType);
> +            else
> +                posAdjust = maxAscent - curr->baselinePosition(baselineType);

I don't understand this at all.  There's nothing wrong with this code as far as I can tell.  You still have to set the correct logicalTop.  You can't just leave it at 0.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.