[Webkit-unassigned] [Bug 54109] [Qt][WK2]Unbreak InjectedBundle on Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54109


Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85598|review?                     |review+
               Flag|                            |




--- Comment #23 from Adam Roben (:aroben) <aroben at apple.com>  2011-03-14 12:09:43 PST ---
(From update of attachment 85598)
View in context: https://bugs.webkit.org/attachment.cgi?id=85598&action=review

> Source/WebKit2/Shared/WebURL.h:72
> +        if (!!m_parsedURL)

No need for the !! here.

> Source/WebKit2/Shared/WebURL.h:74
> +        m_parsedURL.set(new WebCore::KURL(WebCore::KURL(), m_string));

Please use adoptPtr and assignment here instead of OwnPtr::set.

> Tools/WebKitTestRunner/StringFunctions.h:100
> +inline std::ostream& operator<<(std::ostream& out, const WKURLRef urlRef)

No need for the "const" here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.