[Webkit-unassigned] [Bug 54633] [Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54633





--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-14 11:25:53 PST ---
(From update of attachment 84426)
View in context: https://bugs.webkit.org/attachment.cgi?id=84426&action=review

Sorry for the delayed response.  I didn't realize you had uploaded a new patch.  The editing part of the change looks good to me.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:388
> +         || (selection->selection().isCaret() && !selection->selection().isContentEditable())) {

Don't you want to avoid doing this check when caret navigation is on?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.