[Webkit-unassigned] [Bug 56263] XML Viewer: extensions can't render original XML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56263





--- Comment #5 from Adam Barth <abarth at webkit.org>  2011-03-14 11:17:34 PST ---
> 1. XML Viewer defines global javascript function with pseudo-unique name handleWebKitXMLViewerOnLoadEvent(). Extensions could check if this function is defined.
> 2. WebKit xml viewer is not shown when window.opener is defined. Running  window.open(document.location, '_self') will turn xml viewer off.

(2) Seems like a hack.  I'd rather avoid that.  That make the user experience very unpredictable in normal operation. 

> Could be rewritten like  
> 
> if (typeof(window['handleWebKitXMLViewerOnLoadEvent']) == 'function')
>   window.open(document.location, '_self');
> else if (currentDocumentIsXMLWithoutStyle()) 
>   showCustomXMLViewer();

That will make the page flash, right?  It will also require going back to the network.

Maybe that means I don't like the approach...  :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.