[Webkit-unassigned] [Bug 50521] [Qt] Improper rendering of <button> tag when it contains a <br>

Mon Mar 14 07:56:02 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=50521

--- Comment #21 from Dawit A. <adawit at kde.org>  2011-03-14 07:56:02 PST ---
(In reply to comment #19)
> (From update of attachment 85084 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85084&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Please explain your change here. This change is not trivial, even if short. Explaining what is wrong and how your change fix it is useful for future reference when modifying this file.
> > Source/WebCore/platform/qt/RenderThemeQt.cpp:516
> >      // FIXME: Check is flawed, since it doesn't take min-width/max-width into account.
>
> Is this FIXME still valid with your change?

Well, I am not sure what that FIXME pretains to exactly so I cannot say for sure if it does or not. However, hardcoding the width and the height causes text to be clipped in the desktop environment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.