[Webkit-unassigned] [Bug 50521] [Qt] Improper rendering of <button> tag when it contains a <br>

Mon Mar 14 05:30:14 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=50521

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85084|review?                     |review-
               Flag|                            |

--- Comment #19 from Benjamin Poulain <benjamin at webkit.org>  2011-03-14 05:30:14 PST ---
(From update of attachment 85084)
View in context: https://bugs.webkit.org/attachment.cgi?id=85084&action=review

> Source/WebCore/ChangeLog:7
> +

Please explain your change here. This change is not trivial, even if short. Explaining what is wrong and how your change fix it is useful for future reference when modifying this file.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:516
>      // FIXME: Check is flawed, since it doesn't take min-width/max-width into account.

Is this FIXME still valid with your change?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.