[Webkit-unassigned] [Bug 54739] [Qt] Add a Method to QWebHistory to let the browser add items to the tab's history

Mon Mar 14 05:21:25 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=54739

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |jedrzej.nowacki at nokia.com
     Ever Confirmed|0                           |1

--- Comment #6 from Benjamin Poulain <benjamin at webkit.org>  2011-03-14 05:21:25 PST ---
(In reply to comment #5)
> >You forgot the flags :)
> which flags?

"R?" and "C?".
See http://trac.webkit.org/wiki/QtWebKitContrib

> >The type for lastVisited is just mirroring WebKit internal, this is not good for Qt APIs.
> which one to take? qreal?

QDateTime?...

> >And this needs good autotest coverage.
> What do you mean by that? (sorry, my english isn't the best)

When you provide a patch, you should also provide the unittest proving your patch is correct.
Those tests are called "autotests" or "API test" in the context of Qt APIs. You can find the existing tests in Source/WebKit/qt/tests/.

> >Why do you need this at all? Why not serialize the history to QDataStream and >restore it?
> Well, I need to be able to save it in and restore it from a textfile.

We will need something a bit more compelling that that :)
Saving that to a text file is useful if the user can modify the values with a  text editor. What is the use case for that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.