[Webkit-unassigned] [Bug 54443] Textarea maxlength doesn't account for newlines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54443





--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-14 01:39:08 PST ---
(In reply to comment #13)
> Thank you for your review.
> 
> But I cannot understand what is "open typing command".

TypingCommand can be open or closed.  Open means that TypingCommand is still accepting more inputs.  This is necessary to group together multiple input events so that we can undo them at once.

> Could you tell me what kind of situation it happens?

In your patch, you're fixing only when you're adding more inputs to the existing TyingCommand (the last one on the undo stack).  But you don't fix the case where there is no typing command or the TypingCommand which is on the top of the undo stack has already been closed (e.g. by selection change).  So try inserting a line break into <input type="text" value="\n\n\n" maxlength="3">.  I bet your fix won't work in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.