[Webkit-unassigned] [Bug 56247] Alignement problem (list of CPU types requiring alignment is too short)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56247


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2011-03-12 10:42:01 PST ---
Thank you for tackling this.

Please follow the steps in <http://www.webkit.org/coding/contributing.html> precisely to have this landed. Specifically,

- The patch must be marked for review. That makes EWS bots build the patch on several platforms to ensure that it doesn't break the build.
- Please add a properly formatted ChangeLog entry. If you don't write it, who will? Note that prepare-ChangeLog script helps with preparing those.
- Please use svn-create-patch script to make a diff against trunk. A patch that doesn't apply to tip of tree cleanly cannot be landed via commit queue, which automatically verifies that a patch doesn't break the build or regression tests, and generally saves a lot of effort.
- Please land one patch per bugzilla bug. That makes it easier to land via commit queue.

I think that both changes you propose can be made in one patch, there is no need to split them. Your patch is made against some unspecified branch - any fixes need to go to trunk first, and be backported to branches that need it later.

Where does the list of processors that require alignment come from? I'm particularly unsure if we want to include PowerPC.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.