[Webkit-unassigned] [Bug 55989] [GTK] Possible leaks after splitting TextCheckerClientEnchant.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55989





--- Comment #9 from Ryuan Choi <ryuan.choi at samsung.com>  2011-03-12 00:41:42 PST ---
(In reply to comment #7)
> (From update of attachment 85132 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85132&action=review
> 
> Thanks for continuing to clean this code up! I really appreciate it. I've one suggested change.
> 
> > Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:113
> > +                g_utf8_strncpy(word.get(), cstart, end - start);
> 
> We've already calculated the final offset here, why not do this:
> 
> CString word(cstart, bytes);
> int result = enchant_dict_check(dict, word.data(), -1);

Personally, it's my pleasure to contribute something for WebKit and get your review.

I update patch as you mentioned.
Additionally, I thought that some logic will be moved out of nested for loop because it looks not changed in nested for loop.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.