[Webkit-unassigned] [Bug 55844] Expose page dismissal event status through the WebKit API for chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55844





--- Comment #19 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-03-11 14:50:46 PST ---
(From update of attachment 84911)
View in context: https://bugs.webkit.org/attachment.cgi?id=84911&action=review

> Source/WebKit/chromium/public/WebFrame.h:370
> +    virtual bool pageDismissalEventBeingDispatched() const = 0;

have the events already been dispatched or are they just about to be dispatched?
usually, we name methods like this using the "did" or "will" prefix.

willDispatchUnloadEvents or didDispatchUnloadEvents would be a good choices here.

also, i'm a bit confused as to how this will be used.  if the beforeunload dialog
is cancelled (i.e., if the new navigation is cancelled because the user wanted to
stay on the page), then how will the embedder know that?

also, i don't see why this behavior change wouldn't be implemented entirely within
webkit.  i see no reason for their to be a chromium side to this behavior change.
why do you need a webkit api?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.