[Webkit-unassigned] [Bug 56216] New: Rework IconDatabase disabling while allowing for a "pluggable" icon database

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56216

           Summary: Rework IconDatabase disabling while allowing for a
                    "pluggable" icon database
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: beidson at apple.com


Rework IconDatabase disabling while allowing for a "pluggable" icon database.

For WebKit2, we'll want to plug-in a different IconDatabase for both WebCore and WK2 to use.
For WebKit1 mac/win, we want the current WebCore IconDatabase to keep working as it does now.
And for ports who disable the IconDatabase, we want that to keep working.

By making a virtual base "IconDatabaseBase" class for anyone to inherit from, we can accomplish all of the above:

-The "DISABLE(IconDatabase)" folks will just get IconDatabaseBase as a no-op implementation.
-The current WebCore IconDatabase users will get the current IconDatabase code, now inheriting from IconDatabaseBase
-WK2 can make its own IconDatabaseBase subclass and assign it as the current IconDatabase. That will be in a different bug.

Patch for the above refactoring is on its way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.