[Webkit-unassigned] [Bug 56156] Add setting to always force compositing mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 11 11:31:00 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=56156





--- Comment #2 from Vangelis Kokkevis <vangelis at chromium.org>  2011-03-11 11:31:00 PST ---
(From update of attachment 85414)
View in context: https://bugs.webkit.org/attachment.cgi?id=85414&action=review

> Source/WebCore/page/Settings.h:375
> +        void setAlwaysEnterCompositing(bool flag) { m_alwaysEnterCompositing = flag; }

Not a huge fan of the "alwaysEnterCompositing" name (mostly the word "enter"). Possible alternative names that come to mind: alwaysEnableCompositingMode, alwaysUseCompositing, forceCompositingMode, ...

> Source/WebCore/rendering/RenderLayerCompositor.cpp:114
> +    if (settings && settings->alwaysEnterCompositing()) {

We also need to test for m_hasAcceleratedCompositing.  That value is not available at the time the constructor gets called.  Things work fine since there's a check at the end of updateCompositingLayers but it seems somewhat inefficient to go ahead and do all the work, create the GraphicsLayer tree and then gut it all out of compositing isn't supported.

Should this logic maybe move from the constructor to the top of updateCompositingLayers() ?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:725
> +    if (!m_alwaysEnterCompositing || m_renderView->document()->frame()->tree()->parent()) {

Instead of replicating the test for child frames here (which could be fragile if other conditions get added), you could possibly only set m_alwaysEnterCompositing to true in the constructor if your're not dealing with the child frames.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list