[Webkit-unassigned] [Bug 56030] Leaks Viewer: Would like to be able to look at all leaks files from a particular build at once, rather than one at a time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56030


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85486|review?                     |review+
               Flag|                            |




--- Comment #3 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-03-11 10:43:09 PST ---
(From update of attachment 85486)
View in context: https://bugs.webkit.org/attachment.cgi?id=85486&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:58
> +    <script src=LeaksLoader.js></script>
> +    <script src=LeaksParser.js></script>
>      <script src=LeaksViewer.js></script>
> +    <script src=Utilities.js></script>

Nit: You should really use double-quotes around the value of the src attributes.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:65
> +            <span id=loading-indicator-label>Loading…</span>

Nit: And around the id attribute.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.