[Webkit-unassigned] [Bug 56195] New: line 259 in svg/SVGElement.cpp fails to compile on Solaris10/SS12

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56195

           Summary: line 259 in svg/SVGElement.cpp fails to compile on
                    Solaris10/SS12
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: Major
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bentaylor.solx86 at gmail.com
                CC: zimmermann at kde.org


qt-everywhere-opensource-src-4.7.1/src/3rdparty/webkit/WebCore/svg/SVGElement.cpp

Compiling qt-4.7.1 on Solaris 10 with a relatively patched Sun Studio 12 compiler

247 void SVGElement::sendSVGLoadEventIfPossible(bool sendParentLoadEvents)
248 {
249    RefPtr<SVGElement> currentTarget = this;
250    while (currentTarget && currentTarget->haveLoadedRequiredResources()) {
251        RefPtr<Node> parent;
252        if (sendParentLoadEvents)
253            parent = currentTarget->parentNode(); // save the next parent to dispatch too incase dispatching the event changes the tree
254        if (hasLoadListener(currentTarget.get())) {
255            RefPtr<Event> event = Event::create(eventNames().loadEvent, false, false);
256            event->setTarget(currentTarget);
257            currentTarget->dispatchGenericEvent(event.release());
258        }
259        currentTarget = (parent && parent->isSVGElement()) ? static_pointer_cast<SVGElement>(parent) : 0;
260     }
261 }

The error emitted by the compiler is:

"svg/SVGElement.cpp", line 259: Error: Ambiguous "?:" expression, second operand of type "WTF::RefPtr<WebCore::SVGElement>" and third operand of type "int" can be converted to one another.

This patch makes the compilation succeed.

--- qt-everywhere-opensource-src-4.7.1/src/3rdparty/webkit/WebCore/svg/SVGElement.cpp.ORIG      2011-03-09 15:06:34.146973419 +0000
+++ qt-everywhere-opensource-src-4.7.1/src/3rdparty/webkit/WebCore/svg/SVGElement.cpp   2011-03-09 14:40:15.952738383 +0000
@@ -256,7 +256,7 @@
             event->setTarget(currentTarget);
             currentTarget->dispatchGenericEvent(event.release());
         }
-        currentTarget = (parent && parent->isSVGElement()) ? static_pointer_cast<SVGElement>(parent) : 0;
+        currentTarget = (parent && parent->isSVGElement()) ? static_pointer_cast<SVGElement>(parent) : RefPtr<SVGElement>();
     }
 }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.