[Webkit-unassigned] [Bug 56027] Assert that editing does not ignore position's anchorNode if position is an offset in anchor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56027


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85422|review?                     |review-
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2011-03-10 19:29:27 PST ---
(From update of attachment 85422)
View in context: https://bugs.webkit.org/attachment.cgi?id=85422&action=review

Behavior changes need tests.

> Source/WebCore/dom/PositionIterator.cpp:43
> +        if (editingIgnoresContent(m_nodeAfterPositionInAnchor->parentNode()))
> +            return positionBeforeNode(m_anchorNode);

How does this change behavior?  How do we test this?

> Source/WebCore/editing/ApplyStyleCommand.cpp:1699
> +        positionForStyleComparison = firstPositionInOrBeforeNode(startNode.get());

Same question.

> Source/WebCore/editing/htmlediting.cpp:-79
> -           !node->hasTagName(buttonTag) &&

Same question. :)  Buttons are editing boundaries, aren't they?  And aren't their editable kids shadow DOMs?

> Source/WebCore/editing/visible_units.cpp:381
> +    VisiblePosition visPos = startNode->isTextNode() ? VisiblePosition(Position(startNode, static_cast<InlineTextBox *>(startBox)->start(), Position::PositionIsOffsetInAnchor), DOWNSTREAM)

Same qeustion. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.