[Webkit-unassigned] [Bug 56148] [chromium] Graphics Context is not properly recovered if the GPU process dies.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56148


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85397|review?                     |review-
               Flag|                            |




--- Comment #2 from Kenneth Russell <kbr at google.com>  2011-03-10 16:54:03 PST ---
(From update of attachment 85397)
View in context: https://bugs.webkit.org/attachment.cgi?id=85397&action=review

Good work fixing these deep issues; r- for a couple of relatively minor concerns.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:90
> +    PassRefPtr<LayerChromium> rootLayer() { return m_rootLayer.release(); }

I've already given you this feedback offline, but in this form this method should be named something like "releaseRootLayer".

> Source/WebKit/chromium/src/WebViewImpl.cpp:2436
> +            getCompositorContextAttributes(), m_page->chrome(), GraphicsContext3D::RenderDirectlyToHostWindow);

Are any similar improvements needed in WebGLRenderingContext or WebGLLayer?

> Source/WebKit/chromium/src/WebViewImpl.cpp:2443
> +        // TODO(amarinichev): In MacOS newContext->reshape method needs to be

WebKit uses FIXME without an owner, not TODO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.