[Webkit-unassigned] [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55719


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85408|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #37 from Andreas Kling <kling at webkit.org>  2011-03-10 16:43:10 PST ---
(From update of attachment 85408)
View in context: https://bugs.webkit.org/attachment.cgi?id=85408&action=review

As discussed on IRC, this is merely the first step (making it build) towards a proper implementation.

I like the intent of keeping patches incremental and readable, so I'll say r+ here.

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:279
> +void
> +QWKPagePrivate::setComplexTextInputEnabled(uint64_t pluginComplexTextInputIdentifier, bool complexTextInputEnabled)

Coding style, the function return type should not be on a line by itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.