[Webkit-unassigned] [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55719


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85403|review?                     |review-
               Flag|                            |




--- Comment #35 from Andreas Kling <kling at webkit.org>  2011-03-10 16:21:26 PST ---
(From update of attachment 85403)
View in context: https://bugs.webkit.org/attachment.cgi?id=85403&action=review

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:280
> +void
> +QWKPagePrivate::setComplexTextInputEnabled(uint64_t pluginComplexTextInputIdentifier,
> +                                           bool complexTextInputEnabled)

Coding style, this should all be on one line.

> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:140
> -        // FIXME: This is Mac specific.
> +#if PLATFORM(MAC)
>          reply->encode(CoreIPC::MachPort(0, MACH_MSG_TYPE_MOVE_SEND));
> +#else
> +        ASSERT_NOT_REACHED();
> +#endif
>          replyWebProcessProxy->connection()->sendSyncReply(reply);

Why the ASSERT_NOT_REACHED()? It reads to me like we can indeed reach this code.

> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:217
> +

Unnecessary newline.

> Source/WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.cpp:74
> +    connectionIdentifier = 0;
> +    ASSERT(connectionIdentifier);

What's going on here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.