[Webkit-unassigned] [Bug 53409] InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53409





--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-10 14:55:48 PST ---
(From update of attachment 85388)
View in context: https://bugs.webkit.org/attachment.cgi?id=85388&action=review

> Source/WebCore/ChangeLog:8
> +        Fixing broken handling of mixed-editability content for InsertListCommand.

More descriptions?

> Source/WebCore/editing/visible_units.cpp:826
>      Node *node = startNode;

Could you also fix this declaration?  (Node* instead of Node *)

> Source/WebCore/editing/visible_units.cpp:884
> +// FIXME: isStartOfParagraph(startOfNextParagraph(pos)) is not always true

Do we have a bug filed for this?  If not, please file one.

> LayoutTests/editing/execCommand/insert-list-with-noneditable-content-expected.txt:4
> +Editable paragraph containing a non-editable in the middle
> +Another editable paragraph.
> +Insert List

I think we want to use dump as markup here because we'd certainly would like to see what kind of markup we're generating here, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.