[Webkit-unassigned] [Bug 56023] [Chromium] Fix default single selection select's popup background on chromium/linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 10 12:31:03 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=56023


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85365|review?                     |review+
               Flag|                            |




--- Comment #6 from Tony Chang <tony at chromium.org>  2011-03-10 12:31:03 PST ---
(From update of attachment 85365)
View in context: https://bugs.webkit.org/attachment.cgi?id=85365&action=review

> LayoutTests/fast/html/select-dropdown-consistent-background-color.html:20
> +  $('result').textContent=

Nit: add a space before the =

> LayoutTests/fast/html/select-dropdown-consistent-background-color.html:21
> +    (default_color == size0_color && default_color == size1_color) ? "PASS"

Nit: 4 space indent

> LayoutTests/fast/html/select-dropdown-consistent-background-color.html:24
> +    layoutTestController.dumpAsText();

Nit: 4 space indent

> LayoutTests/fast/html/select-dropdown-consistent-background-color.html:34
> +  <option>Item 1</option>
> +  <option>Item 2</option>

Nit: html should probably also use a 4 space indent

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list