[Webkit-unassigned] [Bug 55996] Some Gtk code uses defined(USE_FREETYPE) instead of just USE(FREETYPE)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55996


Alejandro G. Castro <alex at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex at igalia.com




--- Comment #2 from Alejandro G. Castro <alex at igalia.com>  2011-03-10 11:58:47 PST ---
(In reply to comment #1)
> Actually, that would fail due to USE(FOO) assumes WTF_USE_FOO.  I wonder where we're getting USE_FREETYPE from.

It is defined in the Source/WebCore/GNUmakefile.am:

if USE_FREETYPE
webcoregtk_cppflags += \
        -DUSE_FREETYPE=1 \
        -I$(srcdir)/Source/WebCore/platform/graphics/freetype
...

I think it is just an oversight, I would say we should use the macro USE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.