[Webkit-unassigned] [Bug 33008] [Qt] fast/workers/stress-js-execution.html is crashing on Qt bot (intermittently)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33008





--- Comment #18 from Luiz Agostini <luiz at webkit.org>  2011-03-10 08:55:45 PST ---
(In reply to comment #16)
> > Doing the same of what is done when USE(PTHREADS) is true if USE(QT_PTHREAD) is true.
> 
> This comment seems misleading - I was going to ask why we need two macros that do the same. But you are only making it do the same in MachineStackMarker, not everywhere.

Right. :)

> 
> It sounds more like a HAVE-style macro. Or perhaps you could just define USE(PTHREADS) to true in MachineStackMarker.cpp only.

This is what I did first for testing. But now I think that you are right, and it is a lot more simple just to define USE(PTHREADS) in MachineStackMarker.cpp. Last patch does it.

Thanks for your comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.