[Webkit-unassigned] [Bug 56089] [GTK] run-gtk-tests doesn't fail if a test crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56089


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85307|review?                     |review+
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2011-03-10 05:50:44 PST ---
(From update of attachment 85307)
View in context: https://bugs.webkit.org/attachment.cgi?id=85307&action=review

> Tools/Scripts/run-gtk-tests:41
> +    if (!$exitStatus && $?) {
> +        $exitStatus = $?;

No need to check whether exitstatus is already set, I think, just check that $? is non-zero and assign unconditionally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.