[Webkit-unassigned] [Bug 50736] Unable to paste in input[type="text"] with last-child selector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50736


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85237|review?                     |review+
               Flag|                            |




--- Comment #7 from Ojan Vafai <ojan at chromium.org>  2011-03-10 00:18:27 PST ---
(From update of attachment 85237)
View in context: https://bugs.webkit.org/attachment.cgi?id=85237&action=review

> LayoutTests/editing/input/div-first-child-rule-input.html:11
> +// The bug only reproduces on Safari 5 when input is the last element in body

Nit: mentioning a specific Safari version is not useful. All layout tests only reproduce in some previous Safari version. Just because this test was committed after doesn't change what the comment should say.

All I'm saying is s/on Safari 5//.

> LayoutTests/editing/input/div-first-child-rule-textarea.html:11
> +// The bug only reproduces on Safari 5 when textarea is the last element in body

Ditto

> LayoutTests/editing/input/div-first-child-rule-textarea.html:22
> +    if (input.value == 'hello world')
> +        input.parentNode.insertBefore(document.createTextNode('PASS'), input);
> +    else
> +        input.parentNode.insertBefore(document.createTextNode('FAIL'), input);

While I'm nitpicking, it would be more readable to do:
var success = (input.value == 'hello world') ? 'PASS' : 'FAIL';
input.parentNode.insertBefore(document.createTextNode(success), input);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.