[Webkit-unassigned] [Bug 56071] New: [NRWT] We should write an image to the LayoutTest result directory even if driver_output.image is empty.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 21:24:27 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=56071

           Summary: [NRWT] We should write an image to the LayoutTest
                    result directory even if driver_output.image is empty.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hayato at chromium.org
                CC: ojan at chromium.org, dpranke at chromium.org


I've found that the previous test's result image is wrongly shown in the results.html in the following scenario.

Suppose we have a test, foo.html. 

In the first run, the test run successfully and the driver_output.image was written to the LayoutTest result directory as a 'foo-actual.png'.
In the second run, suppose timeout happend. In this case, the driver_output.image was '' (empty string). So test_result_writer will skip writing the image.
As a result, the previous 'foo-actual.png' is used in results.html. That is confusing. The previoius result image was overwritten with empty_image.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list