[Webkit-unassigned] [Bug 55989] [GTK] Possible leaks after splitting TextCheckerClientEnchant.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55989


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85132|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-03-09 13:32:16 PST ---
(From update of attachment 85132)
View in context: https://bugs.webkit.org/attachment.cgi?id=85132&action=review

Thanks for continuing to clean this code up! I really appreciate it. I've one suggested change.

> Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:113
> +                g_utf8_strncpy(word.get(), cstart, end - start);

We've already calculated the final offset here, why not do this:

CString word(cstart, bytes);
int result = enchant_dict_check(dict, word.data(), -1);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.