[Webkit-unassigned] [Bug 53465] Can't remove underline or strike through when selection includes horizontal rule

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53465


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |enrica at apple.com,
                   |                            |jparent at google.com,
                   |                            |kalman at chromium.org,
                   |                            |ojan at chromium.org
     Ever Confirmed|0                           |1




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-09 12:23:14 PST ---
(In reply to comment #0)
> When the current selection includes a horizontal rule and underlined|strike-through text, it's impossible to remove the underlined|strike-through style.  For example, if the selection contains the following:
> 
> <hr><u>foo</u>

More precisely, when the selection starts with hr.  When he appears anywhere else, we can remove / apply text decorations properly.  The problem isn't restricted to text decorations actually. bold, italic, etc... won't work either.

It seems like we're somehow failing to stylize hr.  In the case of br, we can remove the style because we can apply style (e.g. underline results in <u><br>foo</u>).  But then hr isn't a phrasing content so we shouldn't be wrapping it with u, b, and other phrasing elements.  I'll have to look into it.

> it's impossible to remove the underline by running execCommand('underline').  In EditorCommand::executeToggleStyleInList(), selectedCSSValue->cssText() returns "none" in this scenario, which causes this method to think it needs to toggle the style on.  It seems that selectedCSSValue->cssText() should be returning "underline" instead.

I'm not sure if we should be returning underline in this case since the selection starts at hr and hr isn't underlined.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.