[Webkit-unassigned] [Bug 56011] Tiled backing store's delegated scroll request uses incorrect convention

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56011





--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2011-03-09 06:49:43 PST ---
(In reply to comment #3)
> (From update of attachment 85167 [details])
> It is an offset, IntSize is normally used for that. We are not scrolling to a point.

If that's the case, should ScrollView::setScrollPoint be renamed/changed, or should we convert its point to an offset before calling the delegatedScrollRequested method?

(In reply to comment #4)
> (From update of attachment 85167 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85167&action=review
> 
> > Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:435
> > +    QPoint currentPosition(m_webPage->mainFrame()->scrollPosition());
> 
> Where was this done before?

I'm not sure I understand the question, sorry =(. The conversion of the point received by setScrollPoint into an offset is not done anywhere that I could find right now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.