[Webkit-unassigned] [Bug 55457] [NRWT] Add support for reftests to new-run-webkit-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55457





--- Comment #9 from Hayato Ito <hayato at chromium.org>  2011-03-09 02:12:49 PST ---
(In reply to comment #6)
> (From update of attachment 85028 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85028&action=review
> 
> This patch looks fine. Just a few nits. We need to figure out whether we need to add reftests support to run-webkit-tests. That seems like a lot of work, so we might be able to get away with adding a mode to new-run-webkit-tests to run just the reftests and then shelling out from run-webkit-tests to new-run-webkit-tests or just requiring people to run both until new-run-webkit-tests replaces old-run-webkit-tests. In either case, that a discussion to be had on webkit-dev. It doesn't need to block checking this in, but it probably needs to happen before we actually checkin any reftests.

We've discussed that already in the master bug entry. We don't have a plan to add reftest support to run-webkit-tests. And unfortunately, new-run-webkit-tests has not replaced old-run-webkit-tests yet.

So adding a mode to new-run-webkit-test to run just the reftests might be one of the approaches we should take.

We should find a way to satisfying both new-run-webkit-tests and old-run-webkit-tests users.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.