[Webkit-unassigned] [Bug 55150] [Cairo] Better separate the concerns of GraphicsContextCairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55150





--- Comment #6 from Brent Fulgham <bfulgham at webkit.org>  2011-03-08 12:33:11 PST ---
(From update of attachment 84821)
View in context: https://bugs.webkit.org/attachment.cgi?id=84821&action=review

Looks fine to me.  My only minor nit is that the repeated stanzas of code required to go from cairo_t* to GraphicsContext seem unattractive.

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:290
> +        GraphicsContext gc(&platformContext);

Would a GraphicsContext constructor from cairo_t make sense here?  Seems inconvenient to have to create these temporaries if this is done in a lot of places.

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:316
> +    GraphicsContext gc(&platformContext);

Ditto above...

> Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:83
> +    GraphicsContext gc(&platformContext);

Again, declaring a stack temporary just to convert to GraphicsContext.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.