[Webkit-unassigned] [Bug 55938] IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55938





--- Comment #5 from Andrei Popescu <andreip at google.com>  2011-03-08 07:34:07 PST ---
(In reply to comment #3)
> (From update of attachment 85046 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85046&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        https://bugs.webkit.org/show_bug.cgi?id=55938
> 
> Should be ...
> 
> <bug summary>
> <bug url>
> 
> <additional details>
> 
> <test status>
> 

Done.

> > Source/WebKit/chromium/public/WebIDBCallbacks.h:-53
> > -    virtual void onSuccess(WebIDBObjectStore*) { WEBKIT_ASSERT_NOT_REACHED(); }
> 
> Is this a leftover from jorlow's recent patch to remove this method?
> 

No, it's a leftover from my previous patch to remove onscucess(IDBObjectStore). I could not remove that method until doing the Chrome-side changes:

http://src.chromium.org/viewvc/chrome?view=rev&revision=77281

Now that that's in, I can clean this up, too.


> > Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp:31
> > +#include "IDBIndexBackendInterface.h"
> 
> Intentional?

Yes, this was included transitively via WebIDBCallbacks.h. But since I removed it from that header, I had to add it here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.